Trailing comments - #5
Merged
Merged
Conversation
pawamoy
reviewed
Sep 2, 2026
pawamoy
left a comment
pawamoy
left a comment
Member
There was a problem hiding this comment.
Thanks, looking good! Just 2 small comments:
rumpg
force-pushed
the
trailing-comments
branch
from
September 2, 2026 16:16
e365a6e to
df04f83
Compare
pawamoy
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
Adds support for trailing doc comments (on the same line as the attribute assignment).
Assignments spanning multiple lines are not supported.
The PR also contains a fix for the corner case of a file starting with a doc comment, in which case the first line was ignored.
Relevant resources