Fix GRU hidden=None handling for biased new-gate path#3250
Closed
ssmall256 wants to merge 1 commit intoml-explore:mainfrom
Closed
Fix GRU hidden=None handling for biased new-gate path#3250ssmall256 wants to merge 1 commit intoml-explore:mainfrom
ssmall256 wants to merge 1 commit intoml-explore:mainfrom
Conversation
Author
|
I checked prior MLX issues and PRs for duplicates before opening this. I did not find an existing report or fix for this specific |
Member
|
Hi @ssmall256 , thanks for the fix! I hope it's ok but I will merge #3252 instead because it is a bit more concise and efficient. The efficiency comes from avoiding all the computations with 0s when None is passed. Thanks again for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix
nn.GRUsohidden=Noneis treated the same as an explicit zero initial state.Previously, the
hidden=Nonepath skipped the hidden-side new-gate contribution at the first timestep, includingbhn, sogru(x)could differ fromgru(x, hidden=zeros)whenbias=True.This change initializes a zero hidden state before the loop and adds a regression test covering batched and unbatched inputs.
Closes #3249
Tests
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes