fix nn.GRU skipping bhn bias when hidden is None#3252
Merged
angeloskath merged 1 commit intoml-explore:mainfrom Mar 16, 2026
Merged
fix nn.GRU skipping bhn bias when hidden is None#3252angeloskath merged 1 commit intoml-explore:mainfrom
angeloskath merged 1 commit intoml-explore:mainfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
#3249
when
hidden=None(the default), the GRU new-gate computation skips thehidden-side bias
bhnentirely. the first timestep computes:but with an implicit zero hidden state it should compute:
this makes
gru(x)produce different results fromgru(x, hidden=mx.zeros(...))wheneverbias=True.the fix adds an
elifbranch that appliesr * self.bhnwhen there isno hidden state but the bias exists.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes