Add softsign to the nn functions docs - #3989
Merged
Merged
Conversation
zcbenz
approved these changes
Aug 5, 2026
zcbenz
force-pushed
the
docs-add-softsign-function
branch
from
August 5, 2026 02:06
10f9eef to
efc4683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
nn.softsignis missing from the neural network functions list, so it has no page in the docs. TheSoftsignlayer is documented and its docstring points at the function:Since the function has no target, that link is dead. Building with
-nshows it:Every other activation in that file has its functional form listed, including the neighbours
softmax,softmin,softplusandsoftshrink, so this looks like it was just skipped. Adding the entry generatesmlx.nn.softsign.rstand the warning goes away.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes(docs only, one line; verified by building the docs before and after)
as usual, being straight about process: freshman contributor, Claude Code helps me sweep, but i found this by building the docs in nitpick mode, read the actual warning, and checked that every sibling activation is listed before adding it.