Use the current interpreter in the comparative benchmark runner - #4016
Merged
zcbenz merged 1 commit intoAug 6, 2026
Merged
Conversation
zcbenz
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
benchmarks/python/comparative/compare.pyshells out to a literal"python", so it fails immediately on any setup where onlypython3is on PATH, which includes a stock macOS shell:Switched the four subprocess calls to
sys.executable. Besides fixing the crash, this makes the child benchmarks run under the same interpreter as the parent, so runningcompare.pyfrom a virtualenv now benchmarks that environment's MLX rather than whateverpythonhappens to resolve to.mlx.launchalready does the same thing for the same reason (--pythondefaults tosys.executable).After the change the subprocesses actually start, which you can see because
bench_mlx.pygets far enough to parse its own arguments. On this machine the run then stops inbench_torch.pybecause torch is not installed, which is the expected behaviour for a comparison benchmark without torch.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes(no tests since this is a benchmark helper script; verified by running it before and after)
as always, being clear about process: freshman contributor and i use Claude Code to help me look around, but i hit this by actually running the benchmark scripts, and i checked that
sys.executableis the pattern already used elsewhere in the repo before picking it. i also grepped for other hardcoded"python"subprocess calls and did not find any, so this looks like the only spot.