Refactor: Extract set_output Function from utils.h - #4467
Open
JasonHonKL wants to merge 4 commits into
Open
Conversation
|
Rather than randomly fixing the tech-debts, it'd be better if we can create a issue and track what needs to be done there. We can create sub-tickets under that for a tech debt that needs attention |
Contributor
Author
|
Thanks for the recommendations. Usually I would create an issue and fix it however sometime I just randomly explore like this time lolll. So I don't really have a list of "tech-debt" task lolll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts set_output function from normalization.cpp and softmax.cpp.
In total there are 3 same function call but using lambda function currently. This refactor allows us to reuse and reduce the complexity from the code.
Umm I used AI to move the the block to utils.h and understand this function especially the following line haha and also use some it to help me do the formatting and running the testing (I'm lazy to type the command loll)
no_copy &= (s == 0 || s == x.shape().back() || x.shape(-2) == 1);