⚡ Bolt: Optimize Lua server module with O(1) NetworkMap lookups - #232
⚡ Bolt: Optimize Lua server module with O(1) NetworkMap lookups#232mleem97 wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Superseded by consolidated integration PR #235. The reviewed security/performance changes are documented in docs/maintainers/open-pr-audit-2026-08.md. |
1 participant
💡 What: Replaced all
FindObjectsOfType<Il2Cpp.Server>()calls in the Lua Server Module (LuaServerModule.cs) with O(1) dictionary lookups viaIl2Cpp.NetworkMap.instance.servers. Also implemented defensive collection copying during modifications like repairing, while avoiding allocations completely when the collection is empty.🎯 Why:
FindObjectsOfTypescans the entire Unity scene hierarchy (O(N) operation over all loaded objects) and blocks the main thread. When exposed to Lua scripts, these functions can be called very frequently, causing immense CPU overhead and hitches in large data center environments. Utilizing the pre-tracked NetworkMap singletons eliminates this bottleneck entirely.📊 Impact: O(N) operations downgraded to O(1) table iterations. Prevents frame hitches when scripts interact with servers or run frequent scans.
🔬 Measurement: Run Lua scripts that rapidly invoke
greg.server.get_all()orgreg.server.count()and use Unity Profiler or the built-in Diagnostics. NoticeFindObjectsOfTypeis entirely absent from the stack trace in these calls.PR created automatically by Jules for task 12646337491443716356 started by @mleem97