Skip to content

⚡ Bolt: [Performance] Optimize server lookups in LuaServerModule - #234

Closed
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-module-14970877707357245618
Closed

⚡ Bolt: [Performance] Optimize server lookups in LuaServerModule#234
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-server-module-14970877707357245618

Conversation

@mleem97

@mleem97 mleem97 commented Aug 12, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced O(N) FindObjectsOfType<Il2Cpp.Server> calls with O(1) NetworkMap.instance.servers and NetworkMap.instance.brokenServers lookups in LuaServerModule.cs.
🎯 Why: Iterating over the entire scene hierarchy to find servers is slow and blocks the main thread, especially in late-game data centers with many devices.
📊 Impact: Significantly reduces CPU overhead and GC allocations when executing Lua scripts interacting with servers.
🔬 Measurement: Observe lower frame-time spikes in the profiler when Lua scripts query or repair servers.


PR created automatically by Jules for task 14970877707357245618 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

🟢 Metrics 25 complexity · 1 duplication

Metric Results
Complexity 25
Duplication 1

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mleem97

mleem97 commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated integration PR #235. The reviewed security/performance changes are documented in docs/maintainers/open-pr-audit-2026-08.md.

@mleem97 mleem97 closed this Aug 13, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by consolidated integration PR #235. The reviewed security/performance changes are documented in docs/maintainers/open-pr-audit-2026-08.md.

Understood. Acknowledging that this work is superseded and stopping work on this task.

@mleem97
mleem97 deleted the bolt/optimize-lua-server-module-14970877707357245618 branch August 13, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant