Skip to content

Update lab03 - Pull Request Warning #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Update lab03 - Pull Request Warning #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20db06
Update lab03 - Pull Request Warning
eshetty Feb 2, 2024
4f53f82
Update lab03.md
eshetty Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions labs/lab03.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ git checkout

## Exercise 3: Create and approve a pull request

**Note: Please ensure on GitHub, you create the pull request to the main branch of your forked repository. Under no circumstances should you create a pull request to the original PyTorch repository.**
<br><br>
(make sure you choose *username*/pytorch instead of pytorch/pytorch)<br>
<img src="https://github.com/eshetty/s2024/assets/107862033/c874f0a6-abae-478a-af83-0f62eaa8cd4d" alt="image" width="500" height="auto"><br>

1. Create a new branch called `pull-request` from `main` branch.
2. In the `torch/nn/functional.py` file, navigate to the `l1_loss` function (line 3308) and add code to check if the reduction mode is `sum` and raise an exception:
3. Commit the changes to the `pull-request` branch. Make sure you add a meaningful commit message.
Expand Down