feat: equal integration vector#388
Merged
Merged
Conversation
lpatiny
commented
Jul 20, 2026
lpatiny
commented
Member
- feat: add xyEqualIntegrationVector and xEqualIntegrationVectorSimilarity
- chore: do not lint .claude
- fix: matrixApplyNumericalEncoding returned a matrix of zeros
- refactor: compute the rescaling factor once in matrixZPivotRescale
- chore: update dependencies
Split a spectrum in parts of equal integration rather than on centers of mass. A center of mass averages positions, so its splits land between the peaks instead of on them (3.32 and 6.68 for peaks at 2.5/5/7.5), and every point is weighted by its own x value, which lets the noise of a long baseline drag the result. The new splits follow the integration, so they point at the signal and hardly move with a noise as high as the peaks. xyMassCenterVector and xMassCenterVectorSimilarity are deprecated in favor of them and keep their exact behaviour, the latter now delegating so that the similarity algorithm exists only once.
eslint . was descending into the agent worktrees under .claude and reporting errors on stale copies of the sources. The directory is already gitignored.
It started from matrixCreateEmpty instead of the initial matrix, so no value was ever a string, nothing was encoded and the numeric columns were lost. Clone the initial matrix and encode it in place. The test only checked that every value was a number, which a matrix of zeros satisfies, so it now asserts the expected values.
The factor does not depend on the column, it was recomputed on every iteration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 97.13% 97.35% +0.22%
==========================================
Files 207 212 +5
Lines 4147 4232 +85
Branches 1036 1054 +18
==========================================
+ Hits 4028 4120 +92
+ Misses 115 109 -6
+ Partials 4 3 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.