Fix rnnoise only works with 48khz audio#1266
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RNNoise module so it can operate internally at RNNoise’s required 48 kHz while returning audio at the consumer-requested sampling rate, and it improves handling of a rare short-output (“underflow”) scenario by synthesizing an extra padded chunk and carrying excess forward.
Changes:
- Always request/process RNNoise audio at 48 kHz float, then resample back to the originally requested sampling rate.
- Add logic to mitigate rare output shortfalls by processing an extra zero-padded RNNoise block and storing excess in carry buffers.
- Manage a lazily-created resample filter instance and close it during teardown.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/modules/rnnoise/link_rnnoise.c | Resamples link output back to the consumer-requested frequency after RNNoise processing and ensures proper cleanup. |
| src/modules/rnnoise/filter_rnnoise.c | Adds resampling-back support in the filter path and introduces extra-chunk padding to reduce zero-fill underflows. |
This change converts the sampling frequency to whatever was requested by the consumer. It also improves a rare underflow condition in the filter and uses fake samples to fill the gap.
99bfd5e to
1f3a798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change converts the sampling frequency to whatever was requested by the consumer. It also improves a rare underflow condition in the filter and uses fake samples to fill the gap.