Fix uniqueColors comparator strict weak ordering#1818
Merged
ddennedy merged 1 commit intomltframework:masterfrom Apr 28, 2026
Merged
Fix uniqueColors comparator strict weak ordering#1818ddennedy merged 1 commit intomltframework:masterfrom
ddennedy merged 1 commit intomltframework:masterfrom
Conversation
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue in the
uniqueColorssorting comparator where the use of<=violated the requirements of a strict weak ordering. The comparison now uses<instead to restore correct comparator behavior and prevent undefined behavior during sorting.In terms of the algorithm's contract, the comparator used by
std::sortmust induce a strict weak ordering. In particular:a,comp(a, a) == false.comp(a, b) == truethencomp(b, a) == false.Using
<=violated these rules when two elements were equal. Replacing<=with<ensures compliance with the standard and improves stability.Even if equal
QColorare unlikely or impossible to appear inuniqueColors, switching to<is still safe and makes the comparator correct by definition. IfQColorcan never be equal, then<and<=behave the same anyway.References: