Conversation
|
I found it will crash (using Windows) if the rectangle is nearly the size of image. I see messages like the following: That suggests like the filter is rather complex and might be difficult to port. If we move forward with this, we should constrain the rectangle to something like 20% of profile resolution. |
I agree. I looked at the code and I don't think it will be a clean port. I think I would rather start from scratch. It might take me a week or two to come up with something. But we will probably end up abandoning this review. |
|
Closing in favor of this implementation #650 |
I tried this filter in various scenarios and I think it will be pretty useful. However, there are some issues that I don't like:
The avfilter filters do not support keyframes. I expect people would like to be able to keyframe this so that they could remove a spot that is moving.
avfilter.delogo uses absolute pixel positions. This will cause trouble when the project resolution is changed. I know we have that problem now with some other filters. But those will all be resolved when we implement a general solution. This filter could not be fixed with a general solution and would always have this problem unless we implement some kind of filter-specific solution.
avfilter.delogo is very sensitive about the x/y/w/h parameters. If they go outside of the 1 pixel boundary, the filter breaks. This limitation forced me to add more complicated bounds checking to the code. Not terrible, but would rather not have to worry about it.
Feel free to review this pull request. But don't merge it yet. I want to take some time to assess the effort to port the avfilter.delogo code to MLT so that it can use rect properties and keyframing to fix the issues I mentioned above.