Fix rb_mmtk_number_of_mutators#84
Merged
wks merged 1 commit intommtk:dev/mmtk-overrides-defaultfrom Aug 1, 2024
Merged
Conversation
It previously returns the number of threads, including cached threads not executing Ruby code. That is inconsistent with the number of mutators returned from rb_mmtk_get_mutators. This commit reimplementa rb_mmtk_number_of_mutators with rb_mmtk_get_mutators to ensure they see the same number of mutators. Fixes: mmtk/mmtk-ruby#84
wks
added a commit
to wks/mmtk-ruby
that referenced
this pull request
Aug 1, 2024
Updated the `ruby` repo revision to fix a bug where the number of mutators returned from `ActivePlan::number_of_mutators` does not match the number of mutators returned from `ActivePlan::mutators`. Also updated the `mmtk-core` repo revision. More assertions are added so that such bugs can be detected earlier. mmtk-core PR: mmtk/mmtk-core#1182 ruby PR: mmtk/ruby#84 Fixes: mmtk#84
mmtkgc-bot
added a commit
to mmtk/mmtk-ruby
that referenced
this pull request
Aug 2, 2024
Updated the `ruby` repo revision to fix a bug where the number of mutators returned from `ActivePlan::number_of_mutators` does not match the number of mutators returned from `ActivePlan::mutators`. Also updated the `mmtk-core` repo revision. More assertions are added so that such bugs can be detected earlier. mmtk-core PR: mmtk/mmtk-core#1182 ruby PR: mmtk/ruby#84 Fixes: #84 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It previously returns the number of threads, including cached threads not executing Ruby code. That is inconsistent with the number of mutators returned from rb_mmtk_get_mutators. This commit reimplementa rb_mmtk_number_of_mutators with rb_mmtk_get_mutators to ensure they see the same number of mutators.
Fixes: mmtk/mmtk-ruby#84