feat: allow symfony/console 8#75
Merged
Merged
Conversation
canvural
force-pushed
the
symfony8
branch
5 times, most recently
from
a9f09af to
75ee0df
Compare
Owner
|
Thank you! (btw I wouldn't be against dropping support for older versions of PHP and Symfony) |
Contributor
Author
|
Noted. I'm reviving a project that uses Silly from 2 years ago. I might send more PRs. |
|
This broke my existing applications. It does more than just allow Symfony v8, it mandates a |
Owner
|
@shadowhand I don't understand which part of the diff does that, can you point it out? |
shadowhand
reviewed
May 18, 2026
|
|
||
| $this->add($command); | ||
| if (method_exists($this, 'addCommand')) { | ||
| $this->addCommand($command); |
There was a problem hiding this comment.
This breaks any command that doesn't return an int.
You can tell because the author had to add return 0 all over the place.
Owner
There was a problem hiding this comment.
Thank you that's more helpful. @canvural would you be able to look into that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows symfony/console version 8. And upgrades the PHPCSFixer to v3