ENH: Show the current time as a vertical line in plot_evoked_topo#14032
Merged
Conversation
Contributor
Author
|
@Gnefil Could you perform a review on this? |
Gnefil
reviewed
Jul 8, 2026
| _on_time_change, | ||
| fig=fig, | ||
| tmin=np.min([t[0] for t in times]), | ||
| tmax=np.max([t[-1] for t in times]), |
Contributor
There was a problem hiding this comment.
So we choose to take the highest upperbound and the lowest lowerbound, and hide vertical lines for these capped by their times range.
Gnefil
approved these changes
Jul 8, 2026
Gnefil
left a comment
Gnefil
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, clean implementation, and not overloaded test.
5 tasks
Member
|
My only question was going to be about coverage since I don't see any new test, but we must already be covering this code path because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #13968. This adds the time cursor also to the parent figure of
mne.viz.plot_evoked_topo. This behavior mimicks neuromag's xplotter program and was a requested feature in our research group.