Clean up dark/light tests - #14079
Merged
Merged
Conversation
Member
Author
|
Failures appear unrelated but I've seen it before when something breaks in the notebook rendering chain. I'll investigate... |
Member
Author
|
This one seems like a trivial fix and I've confirmed it works on my macOS and Linux machines that had these problems, so I'll mark for merge-when-green |
larsoner
enabled auto-merge (squash)
July 20, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One last part of #14063: make it so that 1) the theme testing works on all OSes (it was actually failing locally for me on Ubuntu 26.04!), and 2) make it so tests consistently use
"light"theming for consistency across dev setups. Investigated and drafted changes using Claude Fable 5 and Opus 4.8, then I revised (and understand + vouch for all changes).