-
Notifications
You must be signed in to change notification settings - Fork 33
ENH: Epochs support #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
572f122 to
acd6cc3
Compare
|
Locally all tests are green now for me 😊 |
78264b7 to
b70ded9
Compare
|
Everything seems to pass except |
30e923c to
585ce07
Compare
585ce07 to
5e43b08
Compare
f104d23 to
bd5dd87
Compare
fe42762 to
8ff5253
Compare
|
@larsoner I think this one would be good to go now: pg_epochs.mp4 |
|
The only issue remaining is #53. |
|
@larsoner When you are fine I think we can merge this one |
|
The last CIs are bound to fail, because mne-tools/mne-python#10297 is not merged yet. But probably merging on mne-python's side first is preferable |
|
I just merged, so maybe CIs just need to be restarted? |
c5c1d3d to
c290cf3
Compare
|
maint/0.24 fails are expected, I will merge this one now |
Description
This is work in progress for epochs support.
mne.viz.tests.test_epochs.pyThis PR depends on a correspondent PR in mne-python.
Code I currently use for testing
REMINDER: CI testing with the PR branch from mne-tools/mne-python#10297 has to be reverted before merging!