BUG: Fixes clicking into Channel-Axis for selecting bad channels #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice, thanks for the swift action on this, @marsipu!!! |
marsipu
force-pushed
the
fix_chax_click
branch
from
3f2af5a to
94ccda8
Compare
marsipu
added a commit
to marsipu/mne-qt-browser
that referenced
this pull request
Feb 11, 2022
marsipu
added a commit
that referenced
this pull request
Feb 14, 2022
* add grid lines * add grid lines to overview-bar * add vline to overview-bar and adapt vline to epochs * facilitate clicking traces * fix scaling (really update shown data) * first plottable epochs (still with issues) * fixing xrange-bugs (but still not color-bug) * fix vline * fix not showing multiple colors * bad toggling * bad colors more consistent * remove debugging remnant * fix precomputing on low epoch count * fixes to pass epochs tests * fix error due to duplication when removing annotation-description * add pyqtgraph-specific tests * unify messagebox-behaviour * fix flake * improve specific pg_test * fix missing attribute annotation_mode * Trying to fix endless CIs 1 * remove bias from speed test * update licenses * refactor speed_test for epochs * add epochs speed test * add epochs speed results to pytest output * try fixing endless CIs * separate test actions * add waiting for precomputed data * fix missing attribute * fix missing n_epochs change * Initialize LoadThread early * Trace init and removal integrated into DataTrace * prevent stacking of LoadThreads * check CIs (must be reverted before merging!) * epoch_idx not similarily retrieved in tickValues and tickStrings of TimeAxis * adapt to changes from #47 * Fix flake * don't show annotations actions for epochs * raise version to invoke epochs-tests * Fix butterfly issues * stabilize scrolling * fix for info._unlocked * add colors to speed_test * epochs speed test for macOS only opengl * unlock info only for epochs * Epochs on MacOS only with OpenGL * revert changes in qt_viz_tests.yml * tone down warning about Epochs and MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #44