Skip to content

BUG: Fixes clicking into Channel-Axis for selecting bad channels #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2022
Merged

BUG: Fixes clicking into Channel-Axis for selecting bad channels #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b708f29
fix clicking between channel labels
marsipu Jan 9, 2022
94ccda8
revert changes from epochs
marsipu Feb 10, 2022
6bf7fdf
fix flake
marsipu Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions mne_qt_browser/_pg_figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ class ChannelAxis(AxisItem):
def __init__(self, main):
self.main = main
self.mne = main.mne
self.ch_texts = dict()
self.ch_texts = OrderedDict()
super().__init__(orientation='left')
self.style['autoReduceTextSpace'] = False

Expand Down Expand Up @@ -380,19 +380,16 @@ def mouseClickEvent(self, event):
if k in [tr.ch_name for tr in self.mne.traces]}
# Get channel-name from position of channel-description
ypos = event.scenePos().y()
ch_name = None
for ch_name in self.ch_texts:
ymin, ymax = self.ch_texts[ch_name][1]
if ymin < ypos < ymax:
break

if ch_name is not None:
trace = [tr for tr in self.mne.traces
if tr.ch_name == ch_name][0]
if event.button() == Qt.LeftButton:
self.main._bad_ch_clicked(trace)
elif event.button() == Qt.RightButton:
self.main._create_ch_context_fig(trace.range_idx)
y_values = np.asarray(list(self.ch_texts.values()))[:, 1, :]
y_diff = np.abs(y_values - ypos)
ch_idx = int(np.argmin(y_diff, axis=0)[0])
ch_name = list(self.ch_texts.keys())[ch_idx]
trace = [tr for tr in self.mne.traces
if tr.ch_name == ch_name][0]
if event.button() == Qt.LeftButton:
self.main._bad_ch_clicked(trace)
elif event.button() == Qt.RightButton:
self.main._create_ch_context_fig(trace.range_idx)

def get_labels(self):
"""Get labels for testing."""
Expand Down