Skip to content

Track read-only fix from VivianBalakrishnan fork #30

@Grivn

Description

@Grivn

Dear Dr. Balakrishnan, @VivianBalakrishnan

I’m Grivn, a developer on the Mnemon project.

I reviewed your read-only fix here:

VivianBalakrishnan@4f7b827

The change looks valuable and appropriate to merge. It addresses a real issue in the current --readonly behavior: commands such as search and recall can still attempt writes through IncrementAccessCount and LogOp. I tested the change against the current mnemon-dev/mnemon master branch; it merges cleanly, and go test ./... passes.

If you are comfortable with it, would you be open to creating an upstream pull request from your fork using this compare link?

master...VivianBalakrishnan:mnemon:master

I also reviewed the Qwen ASR work here:

VivianBalakrishnan#1

That work also looks useful, but I suggest keeping it as a separate feature pull request so that the CLI surface and documentation can be reviewed independently from the read-only fix.

Thank you for identifying and fixing this issue. I believe the read-only fix would make a good focused PR, and I would be glad to help review it.

Best regards,

Grivn

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions