fix: skip writes in IncrementAccessCount and LogOp when read-only#33
Merged
Conversation
DB opened with OpenReadOnly now sets readOnly=true on the struct. IncrementAccessCount and LogOp both return early when readOnly, preventing spurious stderr warnings when mnemon is used against a read-only mount. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR preserves the read-only state on
DBopened viaOpenReadOnly, and makesIncrementAccessCountandLogOpno-op when the database is read-only.Why
searchandrecallare read commands, but they currently still try to update access counts and write oplog entries. Under--readonly, those writes produce unnecessary warnings and violate the expected read-only behavior.Fixes #30.
Validation
build-and-test (1.24)go test ./...