Attempt to fix MOAIImageTexture reallocated on each new glyph rendered#968
Merged
halfnelson merged 1 commit intomoai:masterfrom Sep 6, 2014
Merged
Attempt to fix MOAIImageTexture reallocated on each new glyph rendered#968halfnelson merged 1 commit intomoai:masterfrom
halfnelson merged 1 commit intomoai:masterfrom
Conversation
Contributor
|
Thanks for this |
halfnelson
added a commit
that referenced
this pull request
Sep 6, 2014
Attempt to fix MOAIImageTexture reallocated on each new glyph rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix
MOAIImageTexturetrashing it's glTexId every time aInvalidateAll()is called.This happens because image texture is using
MOAIGfxResource::Load()to force update - after the call it will be inSTATE_PRECREATE, so on next render stepOnCreate()is called. Problem is,Load()destroys texId andOnCreate()will always follow theCreateTextureFromImage()path instead of justUpdateTextureFromImage().This fix is an update of
MOAIGfxResourceto add state switching method without callingOnInvalidate()(which releases texId).In attached text case you can see how log is spammed with TEXTURE +/- events every time a new glyph is added to dynamic cache.