feat: GetSumLastNStatVOs batch request (2.7) - #1
Merged
Conversation
Batch variant of GetSumLastNStatVO: the sum of the last n units of one statClass / granularity for a list of entityIds in one call. The answer is a list of StatVO, one per requested entityId. Used by POST /stats/sumLastNStatVOs (stats >= 5.3) and pm-model's scheduler list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New request class
GetSumLastNStatVOs— the batch variant ofGetSumLastNStatVO: the sum of the lastnunits of onestatClass/statGranularityfor a list of entityIds in one call. The answer is aList<StatVO>, one per requested entityId (entityIdset on each, zeros when the entity has no stats).Version bumped 2.6 → 2.7.
Why
pm-model's
ListCampaignSchedulesRequest(scheduler calendar) called/stats/sumLastNStatVOtwice per campaign schedule — ~3,000 HTTP calls for 1,500 schedules. This is the API half of replacing that with two calls per list request.Consumers:
POST /stats/sumLastNStatVOs(PR opened alongside this one)Notes
mvn deployinci.yml(pull_request_target), which is what publishes 2.7 for the stats / pm-model builds.