Skip to content

test: fix test coverage report, also run server tests - #307

Merged
gmegidish merged 1 commit into
mainfrom
tests-fix-test-coverage-report
Jul 28, 2026
Merged

test: fix test coverage report, also run server tests#307
gmegidish merged 1 commit into
mainfrom
tests-fix-test-coverage-report

Conversation

@gmegidish

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f54bed8a-e2bd-4b63-ad9b-b4f74886a560

📥 Commits

Reviewing files that changed from the base of the PR and between 9b99c19 and 0927eb0.

📒 Files selected for processing (2)
  • Makefile
  • test/server.spec.ts

Walkthrough

The E2E Make target now starts the Node-based test server before running the simulator and coverage reporting commands. Server tests now use a fixed coverage directory under test/, create it recursively, and continue passing it through GOCOVERDIR. UUID-based coverage directory naming has been removed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the intent cannot be assessed from a written description. Add a brief description of the coverage-report fix and the added server test step.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the two main changes: coverage report fixes and running server tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tests-fix-test-coverage-report

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit dbb1e9c into main Jul 28, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant