fix(shell): preserve pane velocity at split extremes - #191
Merged
hamzamerzic merged 2 commits intoJul 24, 2026
Conversation
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
hamzamerzic
commented
Jul 24, 2026
hamzamerzic
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed head ffd78481fa867c6258ffd6b3e50bf5f4e8cf519e against current main.
No blocking code findings. Extending only the short same-edge travel vectors to the 120 ms floor preserves the common average velocity and shared landing frame without adding DOM, timers, render loops, or server work. The extreme 10/90 assertion covers the regression that the earlier proportional-duration floor missed. This remains a compositor-only, bounded calculation over the visible panes.
Landing note: the branch is behind main; update it and require the full checks to rerun before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #183 correctly derived each pane's duration from its travel distance, but its
120ms minimum duration reintroduced the original speed mismatch when one pane
was much smaller than its siblings. At valid 10/90 splits, the short pane could
still move more than twice as slowly as the long pane.
Clamping the duration and accepting that mismatch would hide the symptom. This
follow-up keeps the readable floor and the shared-velocity invariant together:
only panes whose natural trip is too short begin farther offscreen, along their
existing edge vector. The landing geometry, easing, compositor-only transforms,
and synchronized finish remain unchanged.
Verification
mainFollow-up to #183.