Fix stale deletion projections and dismiss notices - #201
Merged
hamzamerzic merged 1 commit intoJul 24, 2026
Conversation
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The offline-capable drawer uses network-first reads, so a successful fallback could return the pre-deletion list even after the server committed the deletion. That briefly restored a dead row; opening it then reached a missing chat and degraded to the new-chat surface. The reverse edge also mattered: reinstall can revive a tombstoned app and hard purge can free an integer id for reuse, so a session tombstone must clear only after the specific app resource is proven live.
The notice primitive also sat over the primary input, one producer bypassed the shared lifecycle, and unrelated shell renders could reset the timeout. Post-commit cleanup failures could additionally report a failed request after the durable state had already changed, recreating ambiguity at the mutation boundary.
Testing
npm run test:lib(1,832 passing)npm run test:hooks(47 passing)npm run build