Complete owned Docker probe cleanup - #209
Merged
hamzamerzic merged 4 commits intoJul 24, 2026
Merged
Conversation
Never fall back to a reusable container name during cleanup. Resolve an immutable ID only when the invocation's private label proves ownership, verify absence without treating daemon uncertainty as success, and let the watchdog remove its private state after a hard kill. Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
…d-cleanup-followup Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
hamzamerzic
added
area: infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This follows up #155. That PR established per-invocation ownership, but a failed CID-file write and an uncertain daemon response could still make cleanup report success without proving absence. The watchdog could then discard the only recovery evidence after a hard kill. This change keeps the same lifecycle helper, makes absence/ownership/uncertainty explicit, and never falls back to deleting a reusable caller-supplied name.
Validation
python3 -m pytest -q backend/tests/test_docker_probe.py(7 passed)bash -n scripts/docker-probe.shgit diff --check