shell: add 'Close all other tabs' to the tab context menu - #273
Closed
miljanm wants to merge 2 commits into
Closed
Conversation
Keeps only the right-clicked tab in its pane; the kept tab becomes active. Pane-scoped: other panes are untouched. One reversible gesture — a single undo snapshot restores every closed sibling. Shown only when a sibling tab exists, in both the single-pane strip and per-pane strips. Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
hamzamerzic
approved these changes
Jul 27, 2026
hamzamerzic
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the complete diff. The action is pane-scoped, same-reference on no-ops, restores the entire prior pane state through one undo snapshot, and leaves other panes untouched. The tests cover the owning model and the menu gate.
Contributor
Author
|
Thanks for the thorough review and the approval! Nothing further needed from our side — ready to merge whenever it suits you. |
5 tasks
Collaborator
|
Reviewed and merged to main through #304, preserving your authorship. The integrated version keeps the Close all other tabs action and its pane-level coverage. Thanks, Miljan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
The tab context menu gains Close all other tabs: it keeps only the right-clicked tab in its pane and makes it the pane's active tab.
Semantics:
CLOSE_PANE.Implementation
paneModel.js: a purecloseOtherTabs(ws, tabKey)(same-reference no-op when the tab is unknown or already alone) plus aCLOSE_OTHER_TABSreducer case with one undo slot.Shell.jsx: one gated menu item between "Close tab" and "Close pane".paneModel.test.js; the menu-item contract inworkspaceUi.test.js.Verification
Unit: the Shell test suite passes (151 tests). Live: drove the running shell end-to-end — opened three tabs, right-clicked one, picked "Close all other tabs"; only the clicked tab remained, in both the menu screenshot and the resulting strip. Undo semantics are covered by the reducer tests.