hack: embed git revison into binaries - #398
Merged
Merged
Conversation
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
force-pushed
the
embed-version
branch
from
May 21, 2018 11:00
7e5c152 to
f350cbe
Compare
tonistiigi
reviewed
May 21, 2018
| @@ -1,2 +1,2 @@ | |||
| bin | |||
| .buildstate | |||
| .tmp | |||
Member
There was a problem hiding this comment.
nit: why is this added here instead of just doing mkdir -p in the Dockerfile
Member
Author
There was a problem hiding this comment.
Actually the directory is created in Dockerfile and this line is unneeded for .dockerignore, but just added for consistency with .gitignore.
tonistiigi
reviewed
May 21, 2018
| FROM gobuild-base AS buildkit-base | ||
| WORKDIR /go/src/github.com/moby/buildkit | ||
| COPY . . | ||
| RUN mkdir .tmp; \ |
Member
There was a problem hiding this comment.
update to my last comment: why create this directory at all?
Member
Author
There was a problem hiding this comment.
So that potentially we can create other files without contaminating the buildkit directory
tonistiigi
approved these changes
May 22, 2018
yui-knk
added a commit
to yui-knk/buildkit
that referenced
this pull request
Jun 30, 2018
The error appears in ``` RUN go build -ldflags "$(cat .tmp/ldflags)" -o /buildctl.exe ./cmd/buildctl ``` and ``` RUN go build -ldflags "$(cat .tmp/ldflags)" -o /buildkitd.exe ./cmd/buildkitd ``` We ignore ".tmp" by ".dockerignore" file, so `COPY . .` does not copy ".tmp". This commit changes the image for "cross-windows" and removes not needed instructions which are done by "buildkit-base". This is follow up of moby#398 Signed-off-by: Yuichiro Kaneko <spiketeika@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
Close #397
Follows containerd convention:
https://github.com/containerd/containerd/blob/cff5e75df87b39c7c4134ccaf58db3abeec46e3d/Makefile#L22-L24