Enabling ILB/ELB on windows using per-node, per-network LB endpoint.#1925
Merged
fcrisciani merged 4 commits intomoby:masterfrom Sep 12, 2017
Merged
Enabling ILB/ELB on windows using per-node, per-network LB endpoint.#1925fcrisciani merged 4 commits intomoby:masterfrom
fcrisciani merged 4 commits intomoby:masterfrom
Conversation
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
Contributor
Author
|
@pradipd looks like there is a compilation error: |
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
Contributor
Author
|
I needed to vendor the latest hcsshim. |
|
@pradipd you can just do |
…work then quickly leaving swarm. This issue was uncovered in TestOverlayAttachableReleaseResourcesOnFailure. Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
fcrisciani
reviewed
Sep 7, 2017
fcrisciani
left a comment
fcrisciani
left a comment
There was a problem hiding this comment.
few nits but overall is fine to me
| } | ||
| } | ||
|
|
||
| //CreateOptionLoadBalancer function returns an option setter for denoting the endpoint is a load balancer for a network |
| } | ||
|
|
||
| if index == -1 { | ||
| logrus.Errorf("Endpoint %s has already been deleted", ep.Name()) |
There was a problem hiding this comment.
Considering that no action is taken, should we move this to warning?
|
|
||
| ilbPolicy, err := hcsshim.AddLoadBalancer(endpoints, true, sourceVIP, vip.String(), 0, 0, 0) | ||
| if err != nil { | ||
| logrus.Errorf("Failed to add ILB policy for service %s (%s) with endpoints %v using load balancer IP %s on network %s: %v", |
There was a problem hiding this comment.
same here, is this an error or a warning? Also do you want to continue with the following logic or return?
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is 1 of 3 PRs (the other 2 are in swarmkit and moby repos).
This change enables ILB/ELB functionality on windows using a per-node, per-network LB endpoint. The per-node, per-network LB endpoint was discussed with docker
as a solution to moby/moby#30820. Note that only windows is using the LB endpoint. We have not changed the linux networking code to take advantage of the LB endpoint.
Signed-off-by: Pradip Dhara pradipd@microsoft.com