Fix github link in docs#2318
Merged
metalivedev merged 1 commit intomoby:masterfrom Oct 22, 2013
Tranquility:master
Merged
Conversation
Contributor
|
Ah. The {{current_version}} is now indeed broken, since we removed the tag 'latest'. But other tags, like v.0.5.3 will still work and I'd prefer to have the docs point to the documentation version they were built from. Could you modify this to have a conditional, like so: note that the dashes (-) are just for not adding line breaks. |
Contributor
Author
|
I changed it. Tell me what you think, I will happily change it again 😃 |
Contributor
|
LGTM. Thanks! |
Contributor
|
ping @metalivedev |
Contributor
|
tested on my rtd image and it works! Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the value of current_version is latest and since there is no branch called latest github is returning a 404 error.