Skip to content

Fix github link in docs#2318

Merged
metalivedev merged 1 commit intomoby:masterfrom
Tranquility:master
Oct 22, 2013
Merged

Fix github link in docs#2318
metalivedev merged 1 commit intomoby:masterfrom
Tranquility:master

Conversation

@Tranquility
Copy link
Copy Markdown
Contributor

Currently the value of current_version is latest and since there is no branch called latest github is returning a 404 error.

@ghost ghost assigned dhrp Oct 21, 2013
@dhrp
Copy link
Copy Markdown
Contributor

dhrp commented Oct 21, 2013

Ah. The {{current_version}} is now indeed broken, since we removed the tag 'latest'. But other tags, like v.0.5.3 will still work and I'd prefer to have the docs point to the documentation version they were built from.

Could you modify this to have a conditional, like so:

{%- if current_version == 'latest' %}
master
{% else %}
{{ current_version }}
{% endif -%}

note that the dashes (-) are just for not adding line breaks.

@Tranquility
Copy link
Copy Markdown
Contributor Author

I changed it. Tell me what you think, I will happily change it again 😃

@dhrp
Copy link
Copy Markdown
Contributor

dhrp commented Oct 22, 2013

LGTM. Thanks!

@crosbymichael
Copy link
Copy Markdown
Contributor

ping @metalivedev

@metalivedev
Copy link
Copy Markdown
Contributor

tested on my rtd image and it works! Thanks for the fix.

metalivedev pushed a commit that referenced this pull request Oct 22, 2013
@metalivedev metalivedev merged commit 3bd4582 into moby:master Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants