Merged
Conversation
names-generator/names-generator.go
Outdated
Contributor
There was a problem hiding this comment.
I think names should all start with lowercase
Contributor
Author
There was a problem hiding this comment.
Ok, I did this because I think CyanAnt is easier to remember/type than cyanant but I can change.
Member
There was a problem hiding this comment.
What about using a hyphen? cyan-ant ?
Contributor
Author
There was a problem hiding this comment.
As solomon said, copy past via double click on with a mouse won't work
Contributor
|
it would be cool if the names where shipping related |
names-generator/names-generator.go
Outdated
Contributor
There was a problem hiding this comment.
Maybe change this to Exists? The gograph already has an method Exists(name string) bool
vieux
pushed a commit
that referenced
this pull request
Oct 28, 2013
Add name generator for container without -name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.