Update docs in docker service create/update for flag --user#25330
Merged
vdemeester merged 1 commit intomoby:masterfrom Aug 2, 2016
Merged
Update docs in docker service create/update for flag --user#25330vdemeester merged 1 commit intomoby:masterfrom
docker service create/update for flag --user#25330vdemeester merged 1 commit intomoby:masterfrom
Conversation
In `docker service create/update`, flag `--user` actually supports `uid:gid` (same as `docker run`). However, this is not reflected in the help and documentation yet. This fix updates docs in `docker service create/update` to change the description to `Username or UID (format: <name|uid>[:<group|gid>])`. The help message output has also been updated. This fix is related to 25304. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Member
|
cool, you beat me to it! LGTM |
thaJeztah
added
status/3-docs-review
process/docs-cherry-pick
and removed
status/0-triage
labels
Member
|
LGTM 👼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
docker service create/update, flag--useractually supportsuid:gid(same asdocker run). However, this is not reflected in the help and documentation yet.This fix updates docs in
docker service create/updateto change the description toUsername or UID (format: <name|uid>[:<group|gid>]).The help message output has also been updated.
This fix is related to #25304.
cc @thaJeztah
Signed-off-by: Yong Tang yong.tang.github@outlook.com