New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug message when client closes websocket attach connection #35720

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@boaz1337
Contributor

boaz1337 commented Dec 6, 2017

- What I did

When the client closes connections that send containers output through websocket, an error message is displayed:
Error attaching websocket: %!s(<nil>)

This message is misleading.

- How I did it

This change suggests to check if error is nil and print the correct message accordingly.
If error is not nil, print Error attaching websocket:. Otherwise, websocket connection was closed by client.

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Add a debug message when client closes websocket attach connection
When the client closes websocket connections that sends container
output through websocket, an error message is displayed:
"Error attaching websocket: %!s(<nil>)"

This message is misleading. Thus, this change suggests to check
if error is nil and print the correct message accordingly.

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
@thaJeztah

SGTM

@dnephin

dnephin approved these changes Dec 8, 2017

LGTM

@thaJeztah thaJeztah merged commit 9f5540f into moby:master Dec 8, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38250 has succeeded
Details
janky Jenkins build Docker-PRs 46992 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7372 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18514 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7195 has succeeded
Details
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 8, 2017

Member

Thanks!

Member

thaJeztah commented Dec 8, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment