Remove all darwin specific files and use more generic _unsupported with build tags.#3857
Merged
vieux merged 3 commits intomoby:masterfrom Jan 31, 2014
Merged
Remove all darwin specific files and use more generic _unsupported with build tags.#3857vieux merged 3 commits intomoby:masterfrom
vieux merged 3 commits intomoby:masterfrom
Conversation
Member
|
many big +1s |
Member
|
If you swap |
Contributor
Author
|
done |
Member
|
Shoot, I told you wrong - reading the docs it should be My brain is fried I think; can someone else verify my broken logic? |
…th build tags. Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes <guillaume.charmes@docker.com> (github: creack)
Member
|
Closes #2544 (in which I had already figured out the necessary flags - I'm updating the files here to actually compile properly and include cross-compiling for linux/arm and linux/i386, and will black-market PR my changes when I'm finished) |
Member
😈 |
… and releasing of linux/386 and linux/arm cross-compiled client binaries Docker-DCO-1.1-Signed-off-by: Andrew Page <admwiggin@gmail.com> (github: tianon)
Member
|
See creack#4 for the black-market PR >:) |
Contributor
|
@creack I'm getting this when running make.sh: |
…6-and-arm-clients Update/fix build tags, Dockerfile, and release.sh for proper building and releasing of linux/386 and linux/arm cross-compiled client binaries
Member
|
@unclejack you should test it again now 👍 |
Contributor
|
LGTM |
Contributor
|
LGTM tested on mac and linux |
vieux
added a commit
that referenced
this pull request
Jan 31, 2014
Remove all darwin specific files and use more generic _unsupported with build tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker-DCO-1.1-Signed-off-by: Guillaume J. Charmes guillaume.charmes@docker.com (github: creack)