some debian init script polishing

[metux]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

Looks like the shfmt settings we use doesn't like some of these formatting changes; https://ci-next.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-42420/runs/1/nodes/251/log/?start=0

You can check the format it wants with; shfmt -w -bn -ci -sr

(The change of order of -p "$DOCKER_PIDFILE" it expects is a bit odd though; looks like it's getting confused by something)

[metux]

hmm, since patch is just for aligning formatting to Debian's version (no idea which one was first) - to make diffing easier - I can move that one to my packager queue and drop it from this submission.

[thaJeztah]

If you're updating, could you also fix the typo in the first commit message? (s/DEAMON/DAEMON/)

[tianon]

I've got to be honest that most of this seems like changes just for changes sake.

For example, I don't see a compelling reason to adjust any of the whitespace in this file (especially since we're now using shfmt to keep all the scripts in the repository consistent), and renaming variables doesn't seem like it really adds much value? Some of your commit messages also reference "debian init script standards" but on my Debian Bullseye system I'm not seeing much consistency between any of the files I have in /etc/init.d, and as a Debian Developer I'm not familiar with any project-wide "standards" for init scripts. The closest thing to that I'm aware of is https://manpages.debian.org/buster/sysvinit-utils/init-d-script.5.en.html, which IMO would actually be a valuable conversion for us to make (but it is Debian-specific). None of the files on my system are using readlink for setting BASE/NAME.

The fact that https://salsa.debian.org/debian/sysvinit/-/blob/21ee620f9aac4d910a769cf3f84c783c19eac199/debian/init-d-script doesn't seem to muck with PID files any more than setting --pidfile makes we wonder if we're maybe doing more than we should be WRT pidfile-related options.

[metux]

@tianon:

The retionale behind this queue: when packaging the upstream tree for Debian family, I've found lots of many differences between moby's and debian's versions. Lots of small things, but summing up to a huge diff.
Consolidating that would make tracking changes on both sides a lot easier.

One thing is actually making a big difference: the last patch is picking the config scriptlet name from the init script's name. If you wanna have multiple instances, you can just copy or hardlink the init script as-is and it will load a separate config. (yes, that's not the cleanest imaginable solutions, but works well enough and often used in the field).