Skip to content

Add back the Ubuntu "Memory and Swap Accounting" section that was lost when the "Kernel" page was culled#4251

Merged
metalivedev merged 1 commit into
moby:masterfrom
tianon:add-back-grub-info
Feb 21, 2014
Merged

Add back the Ubuntu "Memory and Swap Accounting" section that was lost when the "Kernel" page was culled#4251
metalivedev merged 1 commit into
moby:masterfrom
tianon:add-back-grub-info

Conversation

@tianon

@tianon tianon commented Feb 19, 2014

Copy link
Copy Markdown
Member

Fixes #4250

…t when the "Kernel" page was culled

Docker-DCO-1.1-Signed-off-by: Andrew Page <admwiggin@gmail.com> (github: tianon)
@SvenDowideit

Copy link
Copy Markdown
Contributor

@tianon is this ubuntu specific? or should we really create a new .rst and then include it into all the linux's

@metalivedev @jamtur01

@tianon

tianon commented Feb 20, 2014

Copy link
Copy Markdown
Member Author

Well, it applies to Debian and Mint, too.

Only the swapaccout part might apply to other distros, and that depends entirely on how their kernel is compiled. For example, I compile my own kernels and I just have these turned on by default in my config.

@skull-squadron

Copy link
Copy Markdown
Contributor

👍 🍰

@metalivedev

Copy link
Copy Markdown
Contributor

LGTM. If this should be in more Linuxes then we can refactor it as people complain "hey, how come this tip is only in Ubuntu?" but in the meantime I'd rather add to the collective wisdom where we can.

metalivedev added a commit that referenced this pull request Feb 21, 2014
Add back the Ubuntu "Memory and Swap Accounting" section that was lost when the "Kernel" page was culled
@metalivedev metalivedev merged commit 2018d4f into moby:master Feb 21, 2014
@tianon tianon deleted the add-back-grub-info branch February 21, 2014 02:06
@tianon

tianon commented Feb 21, 2014

Copy link
Copy Markdown
Member Author

Just for the record, here's the original: http://docs.docker.io/en/v0.6.3/installation/kernel/#memory-and-swap-accounting-on-debian-ubuntu

"Memory and Swap Accounting on Debian/Ubuntu"

And just to be extra clear, only swapaccount=1 might be useful for other distros (cgroup_enable=memory is specifically for some badly-written Debian/Ubuntu sysvinit scripts...), and it all depends on how their kernels are compiled, so would warrant explicit testing per-distro.

@skull-squadron

Copy link
Copy Markdown
Contributor

It’s a startup. Can’t build Rome in a day. ;)

On Feb 20, 2014, at 6:05 PM, Andy Rothfusz notifications@github.com wrote:

LGTM. If this should be in more Linuxes then we can refactor it as people complain "hey, how come this tip is only in Ubuntu?" but in the meantime I'd rather add to the collective wisdom where we can.


Reply to this email directly or view it on GitHub.

@tianon

tianon commented Feb 24, 2014

Copy link
Copy Markdown
Member Author

Ok, I'm going to have to eat some of my words here. cgroup_enable=memory is definitely needed for at least Debian-based kernels. I don't know if it's needed for any non-Debian-based kernels, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"WARNING: No {swap,memory} limit support" Ubuntu LTS (Precise)

5 participants