gha: set timeouts for buildkit tests#50823
Conversation
The Windows tests sometimes hang until they reach the timeout, but a normal run seems to be ~20 minutes, so adding a 30 minute timeout as it's easier to start it again than having to wait for more than an Hour to see it failed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
kind/enhancement
|
FWIW; added timeouts both for Linux and Windows; not sure if they're in the right spot, but this is an example of a check hanging; https://github.com/moby/moby/actions/runs/17262067500/job/48986448717?pr=50821 cc @crazy-max |
| fi | ||
| echo "TESTFLAGS=${testFlags}" >> $GITHUB_ENV | ||
| - name: Test | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
There was a problem hiding this comment.
And put maybe 40 in
moby/.github/workflows/buildkit.yml
Line 270 in ed8a6a8
There was a problem hiding this comment.
On BuildKit repo we set the timeout to 60 in test flags: https://github.com/moby/buildkit/blob/070d993324ee4f90c0517ca70229dcffa37c270a/.github/workflows/test-os.yml#L81
So maybe for whole job 70?
| *.output=type=docker,name=${{ env.TEST_IMAGE_ID }} | ||
| - | ||
| name: Test | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
Don't think we should for linux and this is already covered by
moby/.github/workflows/buildkit.yml
Line 165 in ed8a6a8
If somehow the runner hangs on Linux like it happens sometimes on Windows, we should update
moby/.github/workflows/buildkit.yml
Line 65 in ed8a6a8
40 instead imo.
There was a problem hiding this comment.
Ah, good call; I missed the --timeout flags; I'll have a look at those. Mostly want to make sure we don't spend hours waiting for something we know is gonna fail 😂
3 participants
The Windows tests sometimes hang until they reach the timeout, but a normal run seems to be ~20 minutes, so adding a 30 minute timeout as it's easier to start it again than having to wait for more than an Hour to see it failed.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)