Skip to content

contrib/check-config: check SCTP protocol option#50906

Merged
akerouanton merged 1 commit intomoby:masterfrom
randomnoise:sctp-check
Sep 8, 2025
Merged

contrib/check-config: check SCTP protocol option#50906
akerouanton merged 1 commit intomoby:masterfrom
randomnoise:sctp-check

Conversation

@randomnoise
Copy link
Copy Markdown
Contributor

- What I did

Added the Stream Control Transmission Protocol (SCTP) Linux kernel config option to 'Optional Features' in contrib/check-config.sh alphabetically.

I added to 'Optional Features' because when the SCTP config option is disabled, Docker is not broken in any major way, and also SCTP's config explanation ends with this line:

CONFIG_IP_SCTP:
...
If in doubt, say N. (exclude)

It seemed more suitable there.

- How to verify it

Run contrib/check-config.sh against host's kernel config:

$ contrib/check-config.sh config-6.16.5-custom | grep IP_SCTP
- CONFIG_IP_SCTP: missing

$ contrib/check-config.sh config-6.14.0-29-generic | grep IP_SCTP
- CONFIG_IP_SCTP: enabled (as module)

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Serhan Tutar <randomnoise@users.noreply.github.com>
@thaJeztah thaJeztah added status/2-code-review kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/contrib labels Sep 5, 2025
@thaJeztah thaJeztah added this to the 29.0.0 milestone Sep 5, 2025
Copy link
Copy Markdown
Member

@akerouanton akerouanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akerouanton akerouanton merged commit 604dfe5 into moby:master Sep 8, 2025
187 checks passed
@randomnoise randomnoise deleted the sctp-check branch September 9, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/contrib kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CONFIG_IP_SCTP, INET_DIAG as implicit dependencies

3 participants