Skip to content

client: client.Ping: allow ForceNegotiate with manual override#51530

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:allow_renegotiate
Nov 14, 2025
Merged

client: client.Ping: allow ForceNegotiate with manual override#51530
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:allow_renegotiate

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Nov 14, 2025

While a manual overridden version shouldn't perform automatic version negotiation, the "ForceNegotiate" option could still be used to (re) negotiate a version. This allows a client to be configured with an initial API version, then triggered to perform API-version negotiation.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

client.Ping: allow `ForceNegotiate` on clients configured with a manual version.

- A picture of a cute animal (not mandatory but encouraged)

While a manual overridden version shouldn't perform automatic version
negotiation, the "ForceNegotiate" option could still be used to (re)
negotiate a version. This allows a client to be configured with an
initial API version, then triggered to perform API-version negotiation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 29.1.0 milestone Nov 14, 2025
@thaJeztah thaJeztah added status/2-code-review kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. impact/changelog area/go-sdk impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Nov 14, 2025
@thaJeztah
Copy link
Copy Markdown
Member Author

Thanks Rob!

@thaJeztah thaJeztah merged commit d9ee22d into moby:master Nov 14, 2025
197 checks passed
@thaJeztah thaJeztah deleted the allow_renegotiate branch November 14, 2025 19:07
@vvoland vvoland removed area/go-sdk impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/changelog kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. module/client status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants