api: update /build/prune and /nodes/{id}/update endpoints to use body instead of query-args #51729
+1,171
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Feldman <mackx@protonmail.com>
Signed-off-by: Max Feldman <mackx@protonmail.com>
Signed-off-by: Max Feldman <mackx@protonmail.com>
Signed-off-by: Max Feldman <mackx@protonmail.com>
Signed-off-by: Max Feldman <mackx@protonmail.com>
Signed-off-by: Max Feldman <mackx@protonmail.com>
Signed-off-by: Aditya Rai <adyrai05@gmail.com>
github-actions
bot
added
area/swarm
area/daemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
We switched the /build/prune and /nodes/{id}/update endpoints to use the request body instead of query-args.
- How I did it
Based on the api version we either use a new implementation or the old implementations for these two endpoints on the client and server sides.
- How to verify it
We wrote tests in daemon/server/router/swarm/cluster_routes_test.go, daemon/server/router/build/build_routes_test.go, client/build_prune_test.go, and client/node_update_test.go to test the new endpoints.
- Human readable description for the release notes
Switch /build/prune and /nodes/{id}/update endpoints to use request body instead of query-args- A picture of a cute animal (not mandatory but encouraged)