user: touch-up GoDoc for MkdirAndChown / MkdirAllAndChown#237
Merged
Conversation
The previous GoDoc was ambiguous about which existing directories have their ownership and permissions updated. In particular, it could be read as applying changes to existing parent directories, while the implementation only updates: - the requested directory (unless WithOnlyNew is specified), and - parent directories that were newly created. Also align the documentation more closely with the corresponding os.Mkdir and os.MkdirAll documentation, and document the key behavioral differences, including the resulting permissions being independent of the process umask. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
user_touchup_docs
branch
from
July 23, 2026 10:53
8d8a3d4 to
8ce2731
Compare
vvoland
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user: touch-up GoDoc for MkdirAndChown / MkdirAllAndChown
The previous GoDoc was ambiguous about which existing directories have
their ownership and permissions updated. In particular, it could be read
as applying changes to existing parent directories, while the
implementation only updates:
Also align the documentation more closely with the corresponding
os.Mkdir and os.MkdirAll documentation, and document the key behavioral
differences, including the resulting permissions being independent of the
process umask.