Github action to build releases with Dune package management#668
Merged
Conversation
c85b875 to
31d95a0
Compare
This adds a dune lockdir to the project and a github action where pushing a tag causes a vpn binary distribution to be built for linux and macos, and released to the github "releases" page. Also fixes a few minor issues which prevented the project from building with the locked versions of dependencies. Signed-off-by: Stephen Sherratt <stephen@sherra.tt> Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
31d95a0 to
58edd66
Compare
Contributor
Author
|
I've fixed the issue I discovered yesterday (broke |
djs55
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an update of the earlier #653 from @gridbugs and incorporates many of Steve's improvements that I have lately upstreamed recently.
As such the main parts are:
setup-duneto download and install Dune, build the dependencies, the project and finally distribution tarballs that are uploaded to the release page on GitHub.3.19.1thus making it impossible to use a modern dune with them (reported by @gridbugs in Upper bounds on the "dune" package prevent dune package management from solving dependencies ocaml/opam-repository-archive#30, possible workaround in Dune discussed in dune should ignore upper bounds on dune ocaml/dune#14637). Thus this PR uses https://github.com/tarides/moby-vpnkit-opam-repository-archive which is a fork of theopam-repository-archivewith the Dune constraint removed.An example can be seen in my testing fork on https://github.com/tarides/moby-vpnkit/releases/tag/2026-05-25.1 where the release was created using the GitHub UI and it automatically triggered the run of this release action which used the locked solution and uploaded the generated tarball to the release automatically. The build took 5 minutes on platforms with fast Github Action runners and a bit under 20 minutes on platforms with slower runners.
cc @djs55
Closes #653.