Update to newer Docker base image to have access to newer software versions#669
Merged
Conversation
Signed-off-by: Marek Kubica <marek@tarides.com>
09d482d to
1cb7101
Compare
djs55
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile used
opam:alpine-3.19-ocamlas a build image, which was created before the opam-repo archival and theopam updatedidn't do anything as it would only consult the local checkout of opam-repository (/home/opam/opam-repository), which did not update anything.This means that e.g. the archived versions of packages are still available and packages are stuck at old versions (e.g. Dune 3.16 released in June 2024).
This PR
FROMline)depextdirectly, so the separate call was removedDockerfilewhich generates an executable as well as theDockerfile.testwhich generates a build log. The build log now contains both unit and E2E test results as we're runningdune buildonly once (dune buildcreates a new_build/logon every run, sodune build @e2ewould overwrite the log ofdune runtest).This should make the setup in the Docker container a bit more futureproof with never versions of software as well as being closer to the set up people need to develop locally (especially the archive repository).
cc @djs55