Skip to content

Update to newer Docker base image to have access to newer software versions#669

Merged
djs55 merged 1 commit into
moby:masterfrom
tarides:update-dockerfile
May 26, 2026
Merged

Update to newer Docker base image to have access to newer software versions#669
djs55 merged 1 commit into
moby:masterfrom
tarides:update-dockerfile

Conversation

@Leonidas-from-XIV
Copy link
Copy Markdown
Contributor

@Leonidas-from-XIV Leonidas-from-XIV commented May 26, 2026

The Dockerfile used opam:alpine-3.19-ocaml as a build image, which was created before the opam-repo archival and the opam update didn't do anything as it would only consult the local checkout of opam-repository (/home/opam/opam-repository), which did not update anything.

This means that e.g. the archived versions of packages are still available and packages are stuck at old versions (e.g. Dune 3.16 released in June 2024).

This PR

  • updates the image to a newer version of Alpine Linux (3.19 is EOL and while it can be made work, might as well switch to a currently supported version since the only change required is the version in the FROM line)
  • Uses opam 2.5, since the image supports it, might as well. This incorporates depext directly, so the separate call was removed
  • Adds the archive repo to include the archived versions of the dependencies
  • Updates both the regular Dockerfile which generates an executable as well as the Dockerfile.test which generates a build log. The build log now contains both unit and E2E test results as we're running dune build only once (dune build creates a new _build/log on every run, so dune build @e2e would overwrite the log of dune runtest).

This should make the setup in the Docker container a bit more futureproof with never versions of software as well as being closer to the set up people need to develop locally (especially the archive repository).

cc @djs55

@Leonidas-from-XIV Leonidas-from-XIV changed the title Update to newer base image to have access to newer versions Update to newer Docker base image to have access to newer software versions May 26, 2026
Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV marked this pull request as ready for review May 26, 2026 09:02
@djs55 djs55 merged commit 56676c4 into moby:master May 26, 2026
5 of 9 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the update-dockerfile branch May 26, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants