Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025

The Icon.Theme property documentation incorrectly stated that custom theme identifiers are allowed. Per the MCP specification schema, theme is an enum with only two valid values: "light" and "dark".

Changes

  • Updated XML doc comment on Icon.Theme to remove "custom theme identifier" claim
  • Aligned description with official schema: explains "light" is for light backgrounds, "dark" for dark backgrounds
  • Added note that clients should assume any-theme compatibility when not specified
- /// Can be "light", "dark", or a custom theme identifier.
- /// The value is used to specify which UI theme the icon is designed for.
+ /// Can be "light" or "dark". "light" indicates the icon is designed to be used with a light
+ /// background, and "dark" indicates the icon is designed to be used with a dark background.
+ /// If not provided, clients should assume the icon can be used with any theme.
Original prompt

This section details on the original issue you should resolve

<issue_title>Icon themes do not support a "custom theme identifier"</issue_title>
<issue_description>It must be light or dark. I don't know where Copilot got this idea from.

- Can be "light", "dark", or a custom theme identifier.
+ Can be "light" or "dark".
```</issue_description>

<agent_instructions>Please review the specification at https://github.com/modelcontextprotocol/modelcontextprotocol/tree/main/schema/2025-11-25 and https://github.com/modelcontextprotocol/modelcontextprotocol/tree/main/docs/specification/2025-11-25 as it applies to icons, and ensure both the shape of the Icon type and related types, as well as the comments on those types are consistent with the specification. The commenter on this issue appears to be correct that only "light" and "dark" are valid, not arbitrary custom values (at least not currently).</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…MCP spec

Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix icon themes to support only light and dark identifiers Fix Icon.Theme documentation to match MCP specification Dec 12, 2025
Copilot AI requested a review from stephentoub December 12, 2025 13:27
@stephentoub stephentoub marked this pull request as ready for review December 12, 2025 13:30
@stephentoub stephentoub enabled auto-merge (squash) December 12, 2025 13:30
@stephentoub stephentoub merged commit 3aedd3c into main Dec 12, 2025
10 checks passed
@stephentoub stephentoub deleted the copilot/fix-icon-themes-identifier branch December 12, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon themes do not support a "custom theme identifier"

3 participants