Skip to content

Fix Icon.Theme documentation to match MCP specification #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 3 commits into from
Dec 12, 2025
+3 −2
Merged

Fix Icon.Theme documentation to match MCP specification #1090

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
305bc1c
Initial plan
Copilot Dec 12, 2025
5ecf557
Fix Icon.Theme documentation to remove "custom theme identifier" per …
Copilot Dec 12, 2025
475becb
Update src/ModelContextProtocol.Core/Protocol/Icon.cs
stephentoub Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/ModelContextProtocol.Core/Protocol/Icon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@ public sealed class Icon
/// Gets or sets the optional theme for this icon.
/// </summary>
/// <remarks>
/// Can be "light", "dark", or a custom theme identifier.
/// The value is used to specify which UI theme the icon is designed for.
/// <see cref="Theme"/> may be "light" or "dark". "light" indicates the icon is designed to be used with a light
/// background, and "dark" indicates the icon is designed to be used with a dark background.
/// If not provided, clients should assume the icon can be used with any theme.
/// </remarks>
[JsonPropertyName("theme")]
public string? Theme { get; set; }
Expand Down