Make the deferred header flush grace configurable - #1795
Open
adityasingh2400 wants to merge 1 commit into
Open
Conversation
The SEP-2575 HTTP status mapping only works while the response headers are still uncommitted. StreamableHttpPostTransport bounded that wait at a fixed 250 ms, so a dispatch slower than the window committed a default 200 and a later JSON-RPC error rode the committed status. That made the mapped status a function of machine scheduling rather than of server behavior. Expose the window as DeferredHeaderFlushGrace on StreamableHttpServerTransport and HttpServerTransportOptions, defaulting to the historical 250 ms so the out-of-the-box behavior is unchanged. Timeout.InfiniteTimeSpan never forces the flush, which makes the mapping deterministic. The raw HTTP conformance tests now disable the bound, and two tests pin both halves of the tradeoff against a handler that runs past the old window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1772.
The SEP-2575 status mapping only holds while the response headers are still uncommitted, and
StreamableHttpPostTransportbounded that wait at a fixed 250 ms. A dispatch slower than that window commits a default 200, so theMissingRequiredClientCapabilityerror arriving afterwards rides the committed status, which is what makesJuly2026Post_MissingRequiredCapability_Returns400depend on machine load rather than on server behavior. This change exposes the window asDeferredHeaderFlushGraceonStreamableHttpServerTransportandHttpServerTransportOptions, keeping the historical 250 ms as the default so nothing changes out of the box, andTimeout.InfiniteTimeSpandisables the bound so the mapping becomes deterministic.The raw HTTP conformance tests now disable the bound so they assert server behavior instead of scheduling, and two new tests pin both halves of the tradeoff against a handler that deliberately runs past the old window. I confirmed the direction of the bug by pinning the grace back to 250 ms against that slow handler and watching the error come back over a committed 200.
Happy to take this a different direction if you would rather drop the bound outright on the JSON response path or solve it purely on the test side.