mcp: handle nil elicitation content with defaults#1068
Open
ychampion wants to merge 1 commit into
Open
Conversation
Constraint: accepted elicitation responses may omit content while schemas still define defaults. Rejected: recover from jsonschema panic | Normalizing content before validation is simpler. Confidence: high Scope-risk: narrow Directive: Keep accepted form elicitation content non-nil before applying defaults. Tested: go test ./mcp -run TestElicitationAcceptNilContentAppliesDefaults -count=1 Tested: go test ./mcp -run 'TestElicitation|TestClientElicitation|TestServerRequestElicit|TestInputRequired' -count=1 Tested: go test ./mcp -count=1 Tested: go test ./... Tested: go vet ./... Tested: gofmt; git diff --check Not-tested: external non-SDK clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentas an empty object before validation.Why
Fixes #1062.
jsonschema-gocan panic when applying defaults into a nil map, so a loose client response could crash the server duringServerSession.Elicit.Validation
go test ./mcp -run TestElicitationAcceptNilContentAppliesDefaults -count=1— failed before the fix withpanic: assignment to entry in nil map; passed aftergo test ./mcp -run 'TestElicitation|TestClientElicitation|TestServerRequestElicit|TestInputRequired' -count=1— passed\n-go test ./mcp -count=1— passed\n-go test ./...— passed\n-go vet ./...— passed\n-gofmt— passed\n-git diff --check— passed