chore(deps): override vulnerable minimatch 3.x to 3.1.5 (ReDoS fixes)#1715
chore(deps): override vulnerable minimatch 3.x to 3.1.5 (ReDoS fixes)#1715cliffhall wants to merge 1 commit into
Conversation
51b5125 to
db2d302
Compare
|
Claude finished @cliffhall's task in 2m 33s —— View job Review: minimatch 3.x → 3.1.5 security override
Verdict: LGTM. The override is correctly scoped, the advisories are fully resolved, and nothing in the tree is broken. Details below. The selector is precise — not just "good enough"I ran
The aggregate vulnerable range is 9.x / 10.x left untouched ✓Confirmed directly in the lockfile:
Version + integrity verified against the registry ✓
Nothing broken ✓
Minor / non-blocking
No actionable defects found. |
Resolves Dependabot alerts #69, #66, #61. Part of #1706. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiccCEh9mwCfVzE8qYcop1
db2d302 to
b71003a
Compare
npm does not reliably apply these transitive overrides to an existing lockfile (bare and targeted overrides via install/update leave residual vulnerable copies). This regenerates the lockfile from scratch with version-targeted overrides so every copy of the affected packages resolves to a patched version. Resolves Dependabot alerts: - esbuild #121 (-> 0.28.1) - minimatch #69, #66, #61 (3.x -> 3.1.5) - @babel/core #132 (-> 7.29.7; completes the partial fix from #1712) Also pins js-yaml overrides (3.15.0 / 4.2.0) to prevent regression. Supersedes #1713, #1714, #1715. Part of #1706. Verified: 0 vulnerable copies across all advisories; build + client (535) + cli tests pass; lockfile internally consistent. Claude-Session: https://claude.ai/code/session_01HiccCEh9mwCfVzE8qYcop1 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Superseded by #1718, which regenerates the lockfile with version-targeted overrides so every transitive copy is patched (npm wouldn't apply these overrides to the existing lockfile minimally, leaving residual vulnerable copies). js-yaml (#1713) was already resolved on main. See #1718 for the verified ALL-CLEAN result. Part of #1706. |
Summary
Adds a version-targeted npm override in the root
package.jsonso that only the vulnerable minimatch 3.x line is bumped, resolving the HIGH-severity ReDoS advisories.The
minimatch@<3.1.4selector scopes the override to the old 3.x line only. The healthy minimatch 9.x and 10.x instances elsewhere in the tree are left completely untouched (never forced down).Verification
npm ls minimatch --allafter the change:minimatch@3.1.5(all former 3.1.2 consumers now deduped to 3.1.5)minimatch@9.0.9— untouchedminimatch@10.2.5— untouched< 3.1.4remainsThe lockfile change is minimal — only the single hoisted
node_modules/minimatchentry moves from 3.1.2 to 3.1.5.npm ciinstalls cleanly against the committed lockfile.Checks
npx prettier --check .— passnpm run check-version— passcd client && npm run lint— passcd client && npm test— pass (535 tests)cd cli && npm test— pass (85 tests)npm run build— passe2e_tests.yml) — skipped (requires Playwright browser download)Resolves Dependabot alerts #69, #66, #61
Part of #1706
🤖 Generated with Claude Code
https://claude.ai/code/session_01HiccCEh9mwCfVzE8qYcop1